D16478: [effects/scale] Port to JavaScript
Vlad Zagorodniy <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
zzag created this revision. zzag added a reviewer: KWin. Herald added a project: KWin. Herald added a subscriber: kwin. zzag requested review of this revision. REVISION SUMMARY Now, when the scripting effects API has all required ingredients to port the Scale effect to JavaScript we finally can do it. The main rationale for porting this effect to JavaScript is that scripted effects API lets us focus more on what we want instead of "how". Visually, the ported version doesn't deviate from the C++ version. TEST PLAN - Enable the Scale effect; - Open/close a window. REPOSITORY R108 KWin BRANCH scripting-grab-ungrab REVISION DETAIL https://phabricator.kde.org/D16478 AFFECTED FILES autotests/integration/effects/slidingpopups_test.cpp autotests/test_builtin_effectloader.cpp autotests/test_plugin_effectloader.cpp autotests/test_scripted_effectloader.cpp effects/CMakeLists.txt effects/effect_builtins.cpp effects/effect_builtins.h effects/scale/CMakeLists.txt effects/scale/package/CMakeLists.txt effects/scale/package/contents/code/main.js effects/scale/package/contents/config/main.xml effects/scale/package/contents/ui/config.ui effects/scale/package/metadata.desktop effects/scale/scale.cpp effects/scale/scale.h effects/scale/scale.kcfg effects/scale/scale_config.cpp effects/scale/scale_config.desktop effects/scale/scale_config.h effects/scale/scale_config.ui effects/scale/scaleconfig.kcfgc kconf_update/kwin.upd To: zzag, #kwin Cc: kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart