D16479: Use override for tabbox classes

Frederik Gladhorn <[email protected]> Mon, 29 Oct 2018 08:47:15 +0000

Newsgroups	gmane.comp.kde.devel.kwin
Message-ID	<[email protected]>

gladhorn added a comment.


  In D16479#350247 <https://phabricator.kde.org/D16479#350247>, @graesslin wrote:
  
  > So far I always said no to such changes as it doesn't really offer advantages for done code and just clutters the commit history.
  
  
  I do think there is a bit advantage: When refactoring and a base classes' function gets renamed, any overriding virtuals will stop compiling, so this kind of change makes the code more future-proof.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D16479

To: gladhorn
Cc: graesslin, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart