D16450: [scripting] Introduce rewind function

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  ++

INLINE COMMENTS

> scriptedeffect.cpp:523
> +        if (!effect->complete(animationId)) {
> +            return QScriptValue(false);
> +        }

There's a minor behavioural difference compared to cancel/retarget.

They return false if animationIds is empty, you return true

(same comment for redirect)

Not a huge issue, but probably worth being consistent.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D16450

To: zzag, #kwin, davidedmundson
Cc: davidedmundson, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart