D16450: [scripting] Introduce complete function

Vlad Zagorodniy <[email protected]>
Newsgroups gmane.comp.kde.devel.kwin
Message-ID <[email protected]>
zzag added inline comments.

INLINE COMMENTS

> davidedmundson wrote in scriptedeffect.cpp:523
> There's a minor behavioural difference compared to cancel/retarget.
> 
> They return false if animationIds is empty, you return true
> 
> (same comment for redirect)
> 
> Not a huge issue, but probably worth being consistent.

Won't QList<quint64> animations(const QVariant &v, bool *ok) take care of that?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D16450

To: zzag, #kwin, davidedmundson
Cc: davidedmundson, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.