D15466: Add Wayland touch drag and drop support

davidedmundson added a comment.


  > Autotest planned.
  
  Did anything come of this?

INLINE COMMENTS

> input.cpp:1521
> +        }
> +        if (m_touchId < 0) {
> +            // We take for now the first id appearing as a move after a drag

So we base the ID of the touch performing the drag based on the first movement after a client creates a grab.

Is that safe?

We know the serial in dragStarted can we take the touch ID from d->globalTouch.ids.key(serial) and then expose that in SeatInterface?

> input.cpp:1536
> +
> +        seat->touchMove(kwaylandId, pos);
> +

should this come after we activate the client?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D15466

To: romangg, #kwin
Cc: davidedmundson, alexde, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart