D16479: Use override for tabbox classes

graesslin added a comment.


  In D16479#350266 <https://phabricator.kde.org/D16479#350266>, @gladhorn wrote:
  
  > In D16479#350247 <https://phabricator.kde.org/D16479#350247>, @graesslin wrote:
  >
  > > So far I always said no to such changes as it doesn't really offer advantages for done code and just clutters the commit history.
  >
  >
  > I do think there is a bit advantage: When refactoring and a base classes' function gets renamed, any overriding virtuals will stop compiling, so this kind of change makes the code more future-proof.
  
  
  I fully understand the advantage of override. I do add it to new code. I'm questioning the advantage of adding it to old and done code. Nobody has touched these classes for years and there won't be any reason to do so for years. And even if one would touch it, it's as simple as doing the change to add override then.
  
  My point against such a change is that we either need to do this for all of KWin or not at all. And for all of KWin I think it's a bad idea as it introduces a commit breaking any git blame. Would you +1 such a change in Qt changing all overriding methods to override?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D16479

To: gladhorn, #kwin
Cc: romangg, graesslin, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart