D16448: [libkwineffects] Port AnimationEffect to TimeLine

davidedmundson added a comment.


  Generally +1

INLINE COMMENTS

> kwinanimationeffect.cpp:308
> +                anim->timeLine.setDirection(TimeLine::Forward);
> +                anim->timeLine.setDuration(std::chrono::milliseconds(newRemainingTime));
> +                anim->timeLine.reset();

This is different.  Though IMHO arguably more correct - please can you check.

Lets say I'm animating opacity 0 to 1 for 10 seconds.

After 5 seconds through I decide I want to make it 15 seconds, so I call retarget(id, 1, 10)

With the old code I'm 1/3 of the way through a 15s animation that goes from 0.5 -> 1   which means my current value is 0.666

With the new code I'm at the start of a 10s animation from 0.5 to 1. Which means my current value is 0.5

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D16448

To: zzag, #kwin
Cc: davidedmundson, abetts, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, apol, mart