D16448: [libkwineffects] Port AnimationEffect to TimeLine

zzag added inline comments.

INLINE COMMENTS

> zzag wrote in kwinanimationeffect.cpp:308
> That's why I posted video of the Morphing Popups. :-)
> 
> IMHO, the behavior of the old code is incorrect. If I retarget animation from the current position to a new position, then there should not be any jumps. Animation should go from the current position to the new target position.
> 
> > With the new code I'm at the start of a 10s animation from 0.5 to 1. Which means my current value is 0.5
> 
> This is the correct behavior, imho. The opacity should go from 0.5 to 1.0, otherwise animation won't be smooth.

... also please notice that the current value of the timeline will go from 0.0 to 1.0.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D16448

To: zzag, #kwin
Cc: davidedmundson, abetts, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, apol, mart