D16454: [effects/fadedesktop] Rewrite it

davidedmundson added inline comments.

INLINE COMMENTS

> zzag wrote in main.js:29
> We don't delete `window.animation`, so we can't just simply redirect the animation.
> 
> Also, from the API standpoint, redirect() can return false, which means it couldn't redirect the animation and some further actions have to be taken (e.g. cancel the animation).
> 
> In order to delete window.animation, I assume we need some inspection mechanism to figure out whether all animations has finished.

> In order to delete window.animation

effect.animationEnded.connect(function(window) {

  delete window.animation;

});

(And if we were doing multiple animations in an array then we change the above code to remove the array entry and delete the property if it's empty)

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D16454

To: zzag, #kwin
Cc: davidedmundson, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart