D16454: [effects/fadedesktop] Rewrite it

davidedmundson added inline comments.

INLINE COMMENTS

> zzag wrote in main.js:29
> Well, we still need
> 
>   if (window.animation) {
>       if (redirect(window.animation, Effect.SomewhereIBelong) {
>           return;
>       }
>       cancel(window.animation);
>   }
>   
>   window.animation = animate({ ... });
> 
> because redirect can fail. It most likely won't happen, but we still need to handle such cases.

AFAIK it can only fail if you call redirect inside a slot directly connected to animationEnded

but sure, we can have that check.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D16454

To: zzag, #kwin
Cc: davidedmundson, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart