D16228: Raise window group together with group transient

graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.


  I'm pretty sure this was intended behavior. The behavior probably exists much longer than I was involved. I assume it was either Lubos or Matthias adding it. Changing code like this has probably more side effects than one can expect. If such a change gets added it must be tested with applications using the window group functionality and it must be tested that applications where one would not expect it to be groups behave correctly. E.g. are multiple konsole/kwrite windows in a group? How does gimp work with the change. I just tested with kwrite and there it is that two kwrite windows have the same group leader. I'm quite certain that you do not want to raise them together.
  
  The problem is that group does not say that the windows belong together. It's more like a place where we can cache window properties (e.g. the icons). But they are not transients, so there is no parent-child relationship. It's more like step-siblings.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D16228

To: zzag, #kwin, graesslin
Cc: graesslin, davidedmundson, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart