D16602: [libkwineffects] Replace property name lookup with calling the virtual methods

davidedmundson planned changes to this revision.
davidedmundson added a comment.


  > when we introduced the property solution we assumed it's not more expensive than the virtual lookup.
  
  Sure, I wasn't trying to criticise the original code (except maybe Qt's code)
  Before blur/background constrast we didn't have effects checking window properties every frame so it wouldn't have been a big issue.
  
  > Please do not add the methods to Toplevel.
  
  Ok
  
  > . I'm sure there's a neat trick
  
  We have two main options:
  
  - We can introduce a class inheriting toplevel that both abstract client and deleted then inherit from
  - We make EffectWindowImpl know about deleted in the newer WINDOW_HELPER_DEFAULT
  
  I'm leaning towards the second option

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D16602

To: davidedmundson, #kwin, graesslin
Cc: graesslin, zzag, broulik, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart