D16682: Fix test of scriptedeffectsloader when run from build directory without install
Martin Flöser <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
graesslin created this revision.
graesslin added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
graesslin requested review of this revision.
REVISION SUMMARY
On build.kde.org all tests loading scripted effects are failing. This
seems to be because the effects are not installed.
To make this work, this change introduces the following changes:
- scripted effects are copied to ${build}/bin, like all binaries
- the test sets XDG_DATA_DIRS env variable to point to ${build}/bin
This change also needs to be added to further tests once this is
accepted. Furthermore it could be considered whether KPackageLoader
should consider the QCoreApplication::applicationDirPath in addition to
the GenericDataLocation. This would make KPackageLoader work much better
in a build tree only setup.
TEST PLAN
Test passes locally, obviously not tried on build.kde.org
REPOSITORY
R108 KWin
BRANCH
effects-install-to-build
REVISION DETAIL
https://phabricator.kde.org/D16682
AFFECTED FILES
autotests/test_scripted_effectloader.cpp
effects/dialogparent/package/CMakeLists.txt
effects/eyeonscreen/package/CMakeLists.txt
effects/fade/CMakeLists.txt
effects/fadedesktop/CMakeLists.txt
effects/frozenapp/package/CMakeLists.txt
effects/login/package/CMakeLists.txt
effects/logout/package/CMakeLists.txt
effects/maximize/package/CMakeLists.txt
effects/scale/package/CMakeLists.txt
effects/squash/package/CMakeLists.txt
effects/translucency/package/CMakeLists.txt
To: graesslin, #kwin
Cc: kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart