D15695: [effects/snaphelper] Do massive overhaul

romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.


  Some small nitpicks. Good to go.

INLINE COMMENTS

> snaphelper.cpp:56
> +        std::chrono::milliseconds(static_cast<int>(animationTime(250))));
> +    m_animation.timeLine.setEasingCurve(QEasingCurve::InOutSine);
>  }

Not linear anymore? Then mention in commit message.

> snaphelper.h:55
>  
>  private:
> +    int m_lineWidth = 4;

Second private. Remove.

> snaphelper.h:56
>  private:
> -    bool m_active;
> -    EffectWindow* m_window;
> -    QTimeLine m_timeline;
> -    //GC m_gc;
> +    int m_lineWidth = 4;
> +    QColor m_lineColor = QColor(128, 128, 128, 128);

Why is it a member variable? Since it does not get changed, better as a static in the cpp file. Same for m_lineColor below.

REPOSITORY
  R108 KWin

BRANCH
  effects-snaphelper-massive-overhaul

REVISION DETAIL
  https://phabricator.kde.org/D15695

To: zzag, #kwin, romangg
Cc: romangg, abetts, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, apol, mart