D16693: [TabBox] Fix Arrow Key / Keyboard Events in QML Alt+Tab Skins

davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
davidedmundson requested review of this revision.

REVISION SUMMARY
  KWin used to do a quirky trick to send key events to the topmost QQuickItem
  rather than things going to the activeFocus item.
  
  Sending it to the window previously would have failed as the window
  didn't think it was active.
  
  Since 66986d4afddcd09c28fe3addb0caa09279eda10f <https://phabricator.kde.org/R108:66986d4afddcd09c28fe3addb0caa09279eda10f> we can just let the
  window process the events in a normal QtQuick manner.
  
  BUG: 370185
  Fixed-in: 5.15.0
  
  It will require tabboxes to set focus correctly.
  The ones I tested did.
  
  Most analysis for this patch was done by Chris Holland.

TEST PLAN
  Held+alt tab with the "Text" tabbox switcher
  pressed up and down

REPOSITORY
  R108 KWin

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16693

AFFECTED FILES
  tabbox/tabboxhandler.cpp

To: davidedmundson, #kwin
Cc: kwin, Zren, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart