D16704: [wayland] add enter/leave virtual desktop API

Vlad Zagorodniy <[email protected]>
Newsgroups gmane.comp.kde.devel.kwin
Message-ID <[email protected]>
zzag added inline comments.

INLINE COMMENTS

> zzag wrote in effects.cpp:921
> If we pass Deleted, then we don't have to do anything. Also, why not qobject_cast?
> 
> Coding style nitpick:
> 
>   auto client = qobject_cast<AbstractClient *>(static_cast<EffectWindowImpl *>(w)->window());
>   if (!client) {
>       return;
>   }
>   
>   VirtualDesktop *desktop = VirtualDesktopManager::self()->desktopForX11Id(desktop);
>   if (!desktop) {
>       return;
>   }
>   
>   client->enterDesktop(desktop);

VirtualDesktop *desktop = VirtualDesktopManager::self()->desktopForX11Id(desktop);
  if (!desktop) {
      return;
  }

This part might be broken because of NET::OnAllDesktops. Sorry.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D16704

To: davidedmundson, #kwin
Cc: zzag, anthonyfieroni, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.