D16731: [effects/slidingpopups] Don't crash when sliding virtual desktops
Martin Flöser <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
graesslin added inline comments.
INLINE COMMENTS
> slidingpopups.cpp:445
> +{
> + auto animationIt = m_animations.constBegin();
> + while (animationIt != m_animations.constEnd()) {
I would use either an iterator based for-loop here or just:
for (auto animationIt: m_animations)
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D16731
To: zzag, #kwin
Cc: graesslin, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart