D15466: Add Wayland touch drag and drop support
Roman Gilg <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
romangg added inline comments. INLINE COMMENTS > davidedmundson wrote in input.cpp:1521 > So we base the ID of the touch performing the drag based on the first movement after a client creates a grab. > > Is that safe? > > We know the serial in dragStarted can we take the touch ID from d->globalTouch.ids.key(serial) and then expose that in SeatInterface? Isn't that what the comment below is about? Where do you see a problem in regards to safety? The ID is only used to specify the drag performing touch point while the touch sequence is ongoing. > davidedmundson wrote in input.cpp:1536 > should this come after we activate the client? I have either argument for or against it. I tested it this way and it worked. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D15466 To: romangg, #kwin Cc: davidedmundson, alexde, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart