D16739: [autotests] Handle async maximisation in quick tiling test
David Edmundson <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
davidedmundson added inline comments. INLINE COMMENTS > zzag wrote in quick_tiling_test.cpp:292 > Could it stay here? It could. Done > graesslin wrote in quick_tiling_test.cpp:292 > could be done. I hardly clear, though. I find it gives some value in the test to see how often the signals are emitted. Especially when having multiple. I found bugs through that. There's definitely value in checking there are no spurious emits - but you can do that with clears or not. I tend to in any tests I write, but I wouldn't rewrite anything, especially when the count only goes to 2. REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D16739 To: davidedmundson, #kwin, graesslin Cc: graesslin, zzag, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart