D16749: Various grammar and capitalization fixes for UI consistency
Albert Astals Cid <[email protected]>
| Newsgroups | gmane.comp.kde.devel.internationalization-and-documentation,gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
aacid added inline comments.
INLINE COMMENTS
> keyboard_layout.cpp:196
> // layout name is translated in the action name in keyboard kcm!
> - const QString action = QStringLiteral("Switch keyboard layout to %1").arg(translatedLayout(it.value()));
> + const QString action = QStringLiteral("Switch Keyboard Layout to %1").arg(translatedLayout(it.value()));
> const auto shortcuts = KGlobalAccel::self()->globalShortcut(componentName, action);
Have you tested this? Because you're breaking things with this change.
Yes the code is incredibly fragile, but i've no idea why you decided to change this given this is not a user visible string.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D16749
To: snoordhuis, #vdg, #localization, yurchor, ngraham
Cc: aacid, ngraham, yurchor, graesslin, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart