D16704: [wayland] add enter/leave virtual desktop API

Vlad Zagorodniy <[email protected]>
Newsgroups gmane.comp.kde.devel.kwin
Message-ID <[email protected]>
zzag added inline comments.

INLINE COMMENTS

> virtual_desktop_test.cpp:247
>      //when it gets on all desktops, it loses all desktops()
>      QCOMPARE(client->desktops().count(), 0u);
>  }

Could we remove the client from the second virtual desktop here? (it should stay on the first and the third virtual desktop)

> kwineffects.h:960
>       */
> -    Q_SCRIPTABLE void removeWindowFromDesktop(KWin::EffectWindow* w, int desktop);
> +    Q_SCRIPTABLE virtual void windowToDesktops(KWin::EffectWindow* w, QVector<uint> desktopIds) = 0;
> +

const QVector<uint> &desktopIds

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D16704

To: davidedmundson, #kwin
Cc: kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.