D16452: [effects/dimscreen] Port to JavaScript
Vlad Zagorodniy <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
zzag added inline comments. INLINE COMMENTS > zzag wrote in main.js:67 > > ... cleaned the animation ID when it ends rather than leaving dangling IDs > > Makes sense. Well, currently, we need to do more work to implement it: set() doesn't return a JavaScript Array object(so, we can't use indexOf, for example), and animationEnded doesn't pass actual animation id (it's always 0). So, I'd like to postpone the cleanup of dangling animation ids. --- Personally, I'd prefer to pass a closure to animate() and set() to get notified when the animation is completed, so the cleanup is more simpler, but I don't think we'll be able to implement something like this any time soon. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D16452 To: zzag, #kwin Cc: davidedmundson, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart