D16865: Unbreak AbstractClient::setDesktop
Martin Flöser <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
graesslin created this revision. graesslin added a reviewer: KWin. Herald added a project: KWin. Herald added a subscriber: kwin. graesslin requested review of this revision. REVISION SUMMARY setDesktop is an important internal API with a given contract: setting the desktop to a specific desktop. It does not mean adding a desktop. setDesktop is used by internal API such as sendClientToDesktop. The intention of such code is pretty clear, it's not to add a client to a desktop. If we want additional API for setting a client to multiple desktop we should add it, not abuse existing internal api. TEST PLAN DesktopPresenceChange test is working again REPOSITORY R108 KWin BRANCH unbreak-set-desktop REVISION DETAIL https://phabricator.kde.org/D16865 AFFECTED FILES abstract_client.cpp To: graesslin, #kwin Cc: kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart