D16449: [scripting] Introduce redirect function

zzag added inline comments.

INLINE COMMENTS

> davidedmundson wrote in anidata_p.h:101
> Instead of
> 
> bool keepAtTarget;
> AnimationEffect::TerminationPolicy  terminationPolicy;
> 
> We have either:
> 
> AnimationEffect::TerminationPolicy targetTerminationPolicy;
> AnimationEffect::TerminationPolicy sourceTerminationPolicy;
> 
> OR
> 
> AnimationEffect::TerminationPolicy terminationPolicy;
> 
> which has flags for {DontTerminate, TerminateAtSource, TerminateAtTarget}
> 
> That then becomes related to this patch as we'd have to name things appropriately

> which has flags for {DontTerminate, TerminateAtSource, TerminateAtTarget}

With TerminateAtTarget, effects can then change type of animation (animate vs set).

> AnimationEffect::TerminationPolicy targetTerminationPolicy;
>  AnimationEffect::TerminationPolicy sourceTerminationPolicy;

If we have the following TerminationPolicy

  enum TerminationPolicy {
      DontTerminate,
      Terminate
  };

maybe it can work out, but I doubt whether it would be simpler than just using two booleans (bool terminateAtSource and bool terminateAtTarget).

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D16449

To: zzag, #kwin
Cc: davidedmundson, abetts, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, sebas, apol, mart