Re: More strict testing requirements?
Martin Flöser <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
Am 2018-11-16 19:03, schrieb Vlad Zagorodniy: > On 11/16/18 7:29 PM, Martin Flöser wrote: >> with build #195 KWin is green again. > > That's awesome! :-) > >> Given the experience I would like to suggest that we setup rules for >> handling failures. >> >> 1. Prior to push ctest should be run locally >> 2. Whenever a test fails on build.kde.org no change is allowed to be >> pushed which does not fix the failure. >> 3. If a failure on build.kde.org is not fixed after 3 days the change >> which introduced the regression gets reverted > > In addition to that, it would be great to see more tighter integration > between CI and Phabricator, something what GitHub folks have for very > long time. Most awesome would be CI building all changes put on phabricator, so that we have a pre-push verification. But something like a comment from ci system about the state of the build would be nice as well. Getting feedback directly is more useful than actively having to check build.kde.org Cheers Martin