D17227: [wayland] Check presence of the inhibitor object when a client is registered in IdleInhibition
David Edmundson <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
davidedmundson added inline comments.
INLINE COMMENTS
> idle_inhibition.cpp:47
> - [this, client] {
> - // TODO: only inhibit if the ShellClient is visible
> - if (client->surface()->inhibitsIdle()) {
You're right on where the problem is, good work analysing.
But this TODO is still valid. From the spec we should only apply the inhibition when the surface is visible.
This is an OK short term fix (if you leave this one line), but when we do it properly we'll have to move it all around.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D17227
To: zzag, #kwin
Cc: davidedmundson, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart