D16602: [libkwineffects] Replace property name lookup with calling the virtual methods

Vlad Zagorodniy <[email protected]> Thu, 29 Nov 2018 23:32:37 +0000

Newsgroups	gmane.comp.kde.devel.kwin
Message-ID	<[email protected]>

zzag added inline comments.

INLINE COMMENTS

> effects.cpp:1751
> +TOPLEVEL_HELPER(bool, isPopupWindow, isPopupWindow)
> +
> +#define CLIENT_HELPER_WITH_DELETED( rettype, prototype, propertyname, defaultValue ) \

#undef TOPLEVEL_HELPER

> effects.cpp:1775
> +
> +//windowClass
> +QString EffectWindowImpl::windowClass() const

Please delete this comment when you're about to push this change.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D16602

To: davidedmundson, #kwin, graesslin
Cc: graesslin, zzag, broulik, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart