D16602: [libkwineffects] Replace property name lookup with calling the virtual methods

David Edmundson <[email protected]> Fri, 30 Nov 2018 10:15:10 +0000

Newsgroups	gmane.comp.kde.devel.kwin
Message-ID	<[email protected]>

davidedmundson updated this revision to Diff 46538.
davidedmundson added a comment.


  - Remove the pointless comment that had got copy pasted into new code
  - undef macros after use
  - Also move the cached properties from EffectWindow to EffectWindowImpl

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16602?vs=46517&id=46538

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16602

AFFECTED FILES
  autotests/test_window_paint_data.cpp
  deleted.cpp
  deleted.h
  effects.cpp
  effects.h
  libkwineffects/kwineffects.cpp
  libkwineffects/kwineffects.h

To: davidedmundson, #kwin, graesslin
Cc: graesslin, zzag, broulik, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart