D16602: [libkwineffects] Replace property name lookup with calling the virtual methods

zzag accepted this revision.
zzag added a comment.


  Looks good to me.
  
  > Hotspot showed it as 5% of the standard render pass (X11) with nothing in kwin animating.
  
  I have a feeling that this statement might be misinterpreted by some folks, like "KWin is now faster". Which is true, but if you use a standalone X11 session, you probably won't notice that.

INLINE COMMENTS

> effects.cpp:1672
> +
> +    waylandClient = toplevel->inherits("KWin::ShellClient");
> +    x11Client = !waylandClient;

Because we're inside of KWin, we can just use qobject_cast. :-)

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D16602

To: davidedmundson, #kwin, graesslin, zzag
Cc: graesslin, zzag, broulik, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart