D17343: [wayland] Don't honor the idle inhibitor object if the surface is not visible

Martin Flöser <[email protected]>
Newsgroups gmane.comp.kde.devel.kwin
Message-ID <[email protected]>
graesslin added inline comments.

INLINE COMMENTS

> idle_inhibition.cpp:112
> +{
> +    const auto stackingOrder = workspace()->stackingOrder();
> +    for (Toplevel *toplevel : stackingOrder) {

You could use Workspace::forEachAbstractClient instead. You probably can get this to a one liner in the connect through std::bind.

> idle_inhibition.h:59
>  
> +private Q_SLOTS:
> +    void slotWorkspaceCreated();

You don't need the Q_SLOTS any more with the new connect syntax.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D17343

To: zzag, #kwin
Cc: graesslin, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.