D17373: Fix heap-use-after-free

davidedmundson added a comment.


  Either ship it, or see my comment and I'll post that.

INLINE COMMENTS

> shadow.cpp:337
> +            auto w = topLevel->effectWindow();
>              // this also deletes the shadow
>              w->sceneWindow()->updateShadow(nullptr);

That was a nasty trap, good thing ASAN was there.

Alternative suggestion: https://phabricator.kde.org/P278

It matches the existing documentation for updateShadow and doesn't have surprise object deletions.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D17373

To: zzag, #kwin
Cc: davidedmundson, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart