D17380: Avoid deleting ourselves midway through updateShadow

davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: KWin.
Herald added a subscriber: kwin.
davidedmundson requested review of this revision.

REVISION SUMMARY
  If updating a shadow means that there should be no shadow, shadow ends
  up deleting itself midway through the method.
  
  It's cleaner and safer to leave that to the caller.
  
  This new change matches the existing documentation for
  Shadow::updateShadow which states
  
  > In case the Property has been withdrawn the method returns @c false.
  >  In that case the owner should delete the Shadow.

TEST PLAN
  Created an ASAN of kwin
  Relevant testMaximised no longer fails

REPOSITORY
  R108 KWin

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17380

AFFECTED FILES
  shadow.cpp
  toplevel.cpp

To: davidedmundson, #kwin
Cc: kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart