D17416: [Effects KCM] Use a better selection color, fix list item size after hiding the effect video and use a real button the play button

ngraham added a comment.


  Cool!
  
  Should these list items even become selected when clicked? Typically items are only selectable when there are some actions you can apply to selected items, which isn't the case here.
  
  Also, since this seems to be an open-ended "improve the Effects KCM" patch, I might recommend showing the video in a tastefully constructed pop-up rather than expanding the height of the corresponding list item to accommodate the video, which just doesn't look good.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D17416

To: GB_2, #kwin, #vdg
Cc: ngraham, #vdg, kwin, #kwin, alexde, IohannesPetros, mkulinski, trickyricky26, ragreen, jackyalcine, Pitel, iodelay, crozbo, ndavis, bwowk, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, hardening, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart