D17416: [Effects KCM] Remove effect list item selection, fix list item size after hiding the effect video, use a real button as the play button and use the right busy indicator
Nathaniel Graham <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
ngraham added inline comments. INLINE COMMENTS > davidedmundson wrote in Effect.qml:36 > I assume this change is > > > Remove effect list item selection > > Why are we removing it? Because UI-wise, there is no point in making something selectable when there is nothing you can do with selected items. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D17416 To: GB_2, #kwin, #vdg, ngraham Cc: davidedmundson, ngraham, #vdg, kwin, #kwin, alexde, IohannesPetros, mkulinski, trickyricky26, ragreen, jackyalcine, Pitel, iodelay, crozbo, ndavis, bwowk, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, hardening, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart