D17483: fix virtual keyboard on Plasma Mobile

graesslin reopened this revision.
graesslin added a comment.
This revision is now accepted and ready to land.


  Guys, code review doesn't make sense if one mobile dev opens a change for another mobile dev and the whole thing gets pushed in five minutes. This gives nobody else a chance to comment. If you want to operate like that you can just omit the review.

INLINE COMMENTS

> main.qml:23
>  import QtQuick.VirtualKeyboard 2.1
> +import org.kde.kirigami 2.5 as Kirigami
>  

This introduces a new dependency on KWin which we otherwise do not use or need. I think it is overkill to use kirigami for this. Please change.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D17483

To: mart, #plasma, bshah
Cc: graesslin, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart