D17537: Unset touch targets on no current touch points

David Edmundson <[email protected]>
Newsgroups gmane.comp.kde.devel.kwin
Message-ID <[email protected]>
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Thanks for fixing.

INLINE COMMENTS

> touch_input.cpp:88
>  
> +bool TouchInputRedirection::atBlocked() const
> +{

It's a weird name. 
It's not like focusUpdateBlocked, where we're blocking changes, but that we want to actively unset "at" next update.

I would suggest something like  "positionValid".

> touch_input.cpp:140
>  
> -    if (old) {
> -        // send leave event to old decoration

Unrelated.  
Please put in a new commit with a new message.

Though the change makes sense, consider it reviewed here.

REPOSITORY
  R108 KWin

BRANCH
  touchCancelFix

REVISION DETAIL
  https://phabricator.kde.org/D17537

To: romangg, #kwin, davidedmundson
Cc: davidedmundson, zzag, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.