D17577: Support for libinput Clickfinger and areas method

atulbi added a comment.


  Yes Next I'm going to unit test once this get finalized

INLINE COMMENTS

> davidedmundson wrote in device.cpp:364
> Current we switch modes, but there's also a:
> 
> LIBINPUT_CONFIG_CLICK_METHOD_NONE
> 
> Is there a need for the KCM to ever set libinput to this?
> 
> ----
> 
> If so as a general rule exposing a 3 state enum states as 2 bools can lead to things becoming more complicated. Especially if we have async connections to the config.

If the user device already has physical buttons

  We need not to change anything
  default setting will be applicable and no ui will be exposed .

else if it doesn't has physical buttons

  then user needs to select either areas or clickfinger mode

So i don't think we ever need to set method as LIBINPUT_CONFIG_CLICK_METHOD_NONE

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D17577

To: atulbi, #kwin, graesslin
Cc: graesslin, davidedmundson, kwin, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart