D17544: virtualkeyboard: report the size of the inputwindow

graesslin added inline comments.

INLINE COMMENTS

> virtualkeyboard.cpp:191
> +    //TODO: move to method
> +    auto adjustInputWindow = [this] {
> +        

?

> virtualkeyboard.cpp:248
> +                if (dec) {
> +                    activeWindowGeom.adjust(dec->borderLeft(), dec->borderTop(), -dec->borderRight(), -dec->borderBottom());
> +                }

Sorry, but this still doesn't work. You are thinking in windows, but these are surfaces. The surface you have could be a sub-surface. You need to map from global space to surface space. IIRC we have a matrix to transform this. See for example: https://api.kde.org/frameworks/kwayland/html/classKWayland_1_1Server_1_1SeatInterface.html#a56910bce41378def01ee27a6e8b8c6fe

But this is for text input surface, not pointer. The pointer surface might be a different to the text input. It might mean we have to add new API to KWayland.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D17544

To: mart, #plasma, #kwin, bshah, graesslin
Cc: graesslin, davidedmundson, kwin, mart, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol