D17700: [kcmkwin/desktop] Add back switching animation setting

Vlad Zagorodniy <[email protected]> Thu, 20 Dec 2018 12:09:32 +0000

Newsgroups	gmane.comp.kde.devel.kwin
Message-ID	<[email protected]>

zzag added a comment.

  In D17700#379820 <https://phabricator.kde.org/D17700#379820>, @hein wrote:

  > if the Effects KCM is similarly hardcoded or not.

  No, effects are not hard coded in the Desktop Effects KCM's model.

  > - The code currently uses hard-coded enumeration of built-in effects. Is there an API to get built-in effects by category?

  Not that I'm aware of. You could get list of all builtin effects and then use std::copy_if, for example.

  > - The code currently used hard-coded enumeration the fadedesktop effect. Is there an API to get installed effects by category?

  Well, you could use KPackage::PackageLoader::findPackages.

  In general, it would be great if we could share the model between the Desktop Effects KCM and this KCM, imho.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D17700

To: hein, mart, ngraham, #kwin
Cc: kwin, zzag, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart