D17265: Ensure consistency when the layout is changed via the dbus protocol
Martin Flöser <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
graesslin added a comment. In D17265#380040 <https://phabricator.kde.org/D17265#380040>, @mart wrote: > In D17265#380034 <https://phabricator.kde.org/D17265#380034>, @graesslin wrote: > > > I have problems following what this change does. All of it has nothing to do with the title. Could you please split this into three commits and reviews for each of the addressed points. > > > well, the thing the patch does is really one, making setting rows work when done via the dbus protocol, i don't think is really splittable No, your change to the dbus interface is one line addition which does not even interact with the changes in virtual desktop manager. Your change might be driven by effects you see in the dbus protocol, but the change you put here has nothing to do with the dbus interface. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D17265 To: mart, #plasma, #kwin, hein, davidedmundson, graesslin Cc: graesslin, davidedmundson, ngraham, kwin, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart