D17265: Ensure consistency when the layout is changed via the dbus protocol

graesslin added inline comments.

INLINE COMMENTS

> virtualdesktops.cpp:596
>              newDesktops << vd;
> +
>              if (m_rootInfo) {

unrelated addition of empty line

> virtualdesktops.cpp:612-614
> +    if (!m_isLoading) {
> +        save();
> +    }

I don't understand this change. The method save has a protection to not do anything when calling save from loading.

> virtualdesktops.cpp:673
> +    m_rows = qMin(m_rows, count());
> +    int columns = count() / m_rows;
>      Qt::Orientation orientation = Qt::Horizontal;

Can we be sure that this is never 0?

> virtualdesktops.cpp:675
>      Qt::Orientation orientation = Qt::Horizontal;
> +
>      if (m_rootInfo) {

unrelated addition of empty line

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D17265

To: mart, #plasma, #kwin, hein, davidedmundson, graesslin
Cc: graesslin, davidedmundson, ngraham, kwin, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart