D17265: Ensure consistency when the layout is changed via the dbus protocol
Martin Flöser <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
graesslin added a comment. In D17265#380071 <https://phabricator.kde.org/D17265#380071>, @hein wrote: > > unrelated addition of empty line > > Hot take: KWin code is nigh-unreadable at times because it tends to be a dense blob devoid of sensible whitespace. Contending with that and then having improvements rejected in review makes KWin extra-despiriting to contribute to. If you think that it needs more empty lines: do add them. But please do it in a separate commit. I find it extremely hard to read the review if all over the place there are additions of empty lines. I always wonder: what is it doing here. And it results in me focusing on stupid bullshit like the empty lines instead of being able to concentrate on the actual change. Yes I'm aware I'm doing a hard review here. There is a very simple reason for this: the description does not match what the code does so I started to question everything what's done here. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D17265 To: mart, #plasma, #kwin, hein, davidedmundson, graesslin Cc: graesslin, davidedmundson, ngraham, kwin, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart