D17265: Fix changing the number of rows via the dbus protocol

mart added a comment.


  empty lines reoved, added more range checks to m_rows to make sure is never 0

INLINE COMMENTS

> graesslin wrote in dbusinterface.cpp:448
> This save doesn't make sense. The option is not saved there, so that save does not work.
> 
> I really don't understand what you want to achieve.

removed on last version

> graesslin wrote in virtualdesktops.cpp:612-614
> I don't understand this change. The method save has a protection to not do anything when calling save from loading.

uhm, where? (tough didn't work as without this saving desktop names gets corrupted and autotests fail without it

> graesslin wrote in virtualdesktops.cpp:673
> Can we be sure that this is never 0?

almost, (the only place is not checking is when taking it from rootinfo)
will add a qmax there too

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D17265

To: mart, #plasma, #kwin, hein, davidedmundson, graesslin
Cc: graesslin, davidedmundson, ngraham, kwin, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart