D17577: Support for libinput Clickfinger and areas method
Vlad Zagorodniy <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
zzag added inline comments.
INLINE COMMENTS
> device_test.cpp:1734
> + QTest::newRow("clickMethodAreas -> clickMethodClickfinger")
> + << (quint32) LIBINPUT_CONFIG_CLICK_METHOD_BUTTON_AREAS << "clickMethodAreas"
> + << (quint32) LIBINPUT_CONFIG_CLICK_METHOD_CLICKFINGER << "clickMethodClickfinger";
Please use static_cast instead of c-style casts.
> mock_libinput.cpp:297
> + if (device->setClickMethodReturnValue == 0) {
> + if (!(device->supportedClickMethods & method) && method!= LIBINPUT_CONFIG_CLICK_METHOD_NONE) {
> + return LIBINPUT_CONFIG_STATUS_INVALID;
missing whitespace before "!="
REPOSITORY
R108 KWin
BRANCH
arcpatch-D17577
REVISION DETAIL
https://phabricator.kde.org/D17577
To: atulbi, #kwin, graesslin, davidedmundson
Cc: zzag, graesslin, davidedmundson, kwin, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart