D17700: [kcmkwin/desktop] Add back switching animation setting

ngraham added a comment.


  UI looks good and works as expected. Thanks for the fast turnaround on this! I have a few code questions:

INLINE COMMENTS

> main.qml:229
> +                }
> +            }
> +

Is all this whitespace between every item really necessary? Or are you just following the existing style?

> virtualdesktops.cpp:3
>   * Copyright (C) 2018 Eike Hein <[email protected]>
> + * Copyright (C) 2009 Martin Gräßlin <[email protected]>
>   *

These should probably be in chronological order

> virtualdesktops.cpp:320
> +    QWidget *showWidget = new QWidget(configDialog);
> +    QVBoxLayout *layout = new QVBoxLayout;
> +    showWidget->setLayout(layout);

Does this need a layout if it will only have one thing in it? Is there a reason we can't put the KCM into the QVBoxLayout that belongs to configDialog?

> virtualdesktops.h:97
> +    QStringList m_switchingEffects;
> +    int m_switchingEffect;
> +    QWindow *m_window;

Could we use an enum for this instead of an int?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D17700

To: hein, mart, ngraham, #kwin
Cc: kwin, zzag, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart