D17700: [kcmkwin/desktop] Add back switching animation setting

hein added inline comments.

INLINE COMMENTS

> ngraham wrote in main.qml:229
> Is all this whitespace between every item really necessary? Or are you just following the existing style?

It's necessary for code readability. I dislike dense code without whitespace, and will generally reject it in patches to codebases I maintain. If you don't put an empty line after a } I will generally dislike your code, it's like writing an essay without paragraph breaks. Readability is a prime concern in writing code.

> ngraham wrote in virtualdesktops.cpp:320
> Does this need a layout if it will only have one thing in it? Is there a reason we can't put the KCM into the QVBoxLayout that belongs to configDialog?

Dunno, don't care. It's existing code copied over, there's no need to change and possibly break it.

> ngraham wrote in virtualdesktops.h:97
> Could we use an enum for this instead of an int?

Not really. Keep in mind that as per Vlad's comments, the whole thing is supposed to eventually be extensible, and there's no way to enumerate unknown effects ahead of time.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D17700

To: hein, mart, ngraham, #kwin
Cc: kwin, zzag, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart