D17748: Try to make TestShellClient::testUnresponsiveWindow more robust
Martin Flöser <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
graesslin created this revision. graesslin added a reviewer: KWin. Herald added a project: KWin. Herald added a subscriber: kwin. graesslin requested review of this revision. REVISION SUMMARY When looking at the test results on build.kde.org we see this is the test which fails most often and it's always at the same line of code. So I just had a look with the thought: "what's special about this code, why could it fail?" Looking at it we start an external process which is supposed to connect to KWin. We wait for the process to start and then wait for the shell client added. This assumes that at the time we handle the wait for started the connection of the window has not happened yet. Thinking about it, it's possible that we get the wait for started after we added the window. So this change tries to catch this special condition. REPOSITORY R108 KWin BRANCH shell-client-test-robustness REVISION DETAIL https://phabricator.kde.org/D17748 AFFECTED FILES autotests/integration/shell_client_test.cpp To: graesslin, #kwin Cc: kwin, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart