D17765: [kcmkwin] Extract effects model into a shared library
Vlad Zagorodniy <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
zzag created this revision. zzag added a reviewer: KWin. Herald added a project: KWin. Herald added a subscriber: kwin. zzag requested review of this revision. REVISION SUMMARY The main motivation for moving it into a shared library is to share the model between Desktop Effects and Virtual Desktops KCM. The extracted model is quite the same as the one in Desktop Effects KCM, except some minor changes, e.g. rename loadEffect and syncConfig to more convenient names, add comments, some whitespace changes, fix coding style in some parts, etc. TEST PLAN effectModelTest passes, Desktop Effects KCM works. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D17765 AFFECTED FILES kcmkwin/CMakeLists.txt kcmkwin/common/CMakeLists.txt kcmkwin/common/Messages.sh kcmkwin/common/effectmodel.cpp kcmkwin/common/effectmodel.h kcmkwin/kwincompositing/CMakeLists.txt kcmkwin/kwincompositing/model.cpp kcmkwin/kwincompositing/model.h kcmkwin/kwincompositing/test/effectmodeltest.cpp To: zzag, #kwin Cc: kwin, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart