D17890: Move groupTransient and group from Client to AbstractClient as virtual
Martin Flöser <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
graesslin added inline comments. INLINE COMMENTS > zzag wrote in abstract_client.h:758 > If it's X11 specific, doesn't it make sense to keep groupTransient in Client? The reason I moved it is that we need to cast in Workspace and similar places. The casts are a problem. Every cast is a potential "forgot to port". I recently stumbled over a few and thought: let's try to get rid of all. We have more such API in AbstractClient: e.g. shade is only in X11. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D17890 To: graesslin, #kwin Cc: zzag, kwin, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart