D17898: Cast to AbstractClient instead of Client in Toplevel::setReadyForPainting
Vlad Zagorodniy <[email protected]>
| Newsgroups | gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
zzag added a comment.
Off-topic: should we put whitespace between a type and "*" in static_cast/qobject_cast/reinterpret_cast/etc?
INLINE COMMENTS
> toplevel.cpp:265
> emit windowShown(this);
> - if (Client *cl = dynamic_cast<Client*>(this)) {
> + if (auto *cl = dynamic_cast<AbstractClient*>(this)) {
> if (cl->tabGroup() && cl->tabGroup()->current() == cl)
While we're on this, would it be feasible to use qobject_cast instead?
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D17898
To: graesslin, #kwin
Cc: zzag, kwin, GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk, ZrenBot, ngraham, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart